Started 1 yr 4 mo ago
Took 42 min on reynolds

Build #119 (Jan 11, 2022, 4:58:25 AM)

  1. Added to DeveloperEmailAddresses (details)
  2. added annotation (details)
  3. intermediate commit in case of ACDL power down. sandbox still should not compile yet (details)
  4. refactored 3D box hex grid to allow for arbitrary list of node coordinates (details)
  5. added DOF count checks in box hex grid (details)
  6. added CG field instantiation for IBL3 Qauxv field (details)
  7. minor annotation (details)
  8. refactoring to show intention more clearly (details)
  9. minor cleanup (details)
  10. minor addition of annotation (details)
  11. cleaned up and fixed sandbox case on FP for S-shaped duct (details)
  12. commented out hacks (details)
  13. Starting to implement BCDataFields by copying over stuff (details)
  14. added and experimented with BCDataFieldManager class.  Ready to further extend this for BCDataField implementation. (details)
  15. minor commenting (details)
  16. minor refactoring before adding BC data field stuff (details)
  17. Initial prototype of introducing BC data fields into algebraic equation set and instantiations of IntegrandBoundaryTraces (details)
  18. trying to equip IntegrandBoundaryTrace with BCDataField: succeed in contructor but failed due to preset Integrand type defi in IntegrateBoundaryTrace_Dispatch.dispatch() turning off all the hacks, which will be removed in the future (details)
  19. some tidying up (details)
  20. hide away to-be-removed stuff/hacks (details)
  21. Refactored 3D full potential stuff, particularly adding wall transpiration BC.  Start to pave ways for including BC data field in BC class (details)
  22. Tried wall transpiration in S-duct FP case (details)
  23. append BC data field to 3D FP wall transpiration BC (details)
  24. renaming variables for clarity (details)
  25. Enabled using BC data field by passing it to the BC class.  Tested on full potential 3D case.  Removed previous attempt of trying to let integrand class to own BC data field (details)
  26. removed code from a previous attempt to implement BC data field (details)
  27. refactored BC data evaluation call from element (details)
  28. Started working on Auxv projection equation for IBL+FP coupling: finished the qauxv component in the projection integrand (details)
  29. minor refactoring to reduce unnecessary memory allocation (details)
  30. modulize velocity calculation in 3D FP solver (details)
  31. typo fixes (details)
  32. Added new 4-variable Qauxv formulation and associated Field instantiations (details)
  33. Initial work on Auxv equation with 3D FP solver: compiles now but needs to be completed (details)
  34. Some cleanup on Auxv equation (with 3D FP) residual (details)
  35. some more cleanup before completing Auxv equation jacobian (details)
  36. Auxv equation now works for a trivial test case.  Now need to work out volume-surface grid connectivity (details)
  37. minor cleanup (details)
  38. minor refactoring/annotation (details)
  39. Initial work on contructing surface mesh corresponding to a boundary group of volume mesh (BoxHex). TBD: Needs nontrivial testing and interior trace groups (details)
  40. Added nontrivial test for Auxv projection from FP solution (details)
  41. minor typo fix in comments (details)
  42. Added interior trace elements to the boundary surface mesh of BoxHex.  Tried/verfified solving IBL3 on this surface mesh in the flat plate laminar BL case (details)
  43. minor cleanup (details)
  44. minor cleanup/refactoring (details)
  45. Removed execute permission for a .cpp file (details)
  46. Add surface tecplot dump to BodyForce Solver (details)
  47. Fix for body force surface outputs (details)
  48. Added Pointwise mesh generator (details)
  49. Parallel fix and forgot a file (details)
  50. Fix Pointwise h calculation. Fix link errors. (details)
  51. Small fix to Pointwise glf script (details)
  52. Added to DeveloperEmailAddresses (details)
  53. PDERANSSA2D changes which take out ntref as a variable in the PDERANS function and unit test. The unit test update is not ideal right now since I am still waiting on a way to calculate some terms, but there is a SANS developer exception for the time being. Needed to push it to start building off some new SA varaitions off of it. (details)
  54. Removing white spaces in PDERANSSA2D (details)
  55. Add isotropic MOESS optimization option for Pointwise (details)
  56. Fixes to PDERANSSA2D and unit test (details)
  57. Another formatting change (details)
  58. Try again (details)
  59. messed up spacing at the end of the file (details)
  60. Valgrind python suppressions (details)
  61. Nightly clang analyzer suppressions (details)
  62. Correct volume calculation for Pointwise (details)
  63. Pointwise fix for dimensionality (details)
  64. changes to sandbox cases with nuref defined (details)
  65. Fix instantiation (details)
  66. Clang compiler fix (details)
  67. Relax timing for one test (details)
  68. More changes to sandbox cases for nuref deletion update (details)
  69. Initilizing variables and raising the convergence tolerance (details)
  70. Just lowering the tolerance a little bit more on the PDERANS unit test to try and get it through Intel. I need to update this later anyway so this may be a temporary fix (details)
  71. Actually finding that closetol is defined multiple times in this unit test (details)
  72. Use Python 3.8.10 for valgrind and sanitizer (details)
  73. Messing around with the tolerances a little bit more (details)
  74. Improved linesearch console output. Now when verbosity is on, the linesearch outputs whether a residual is increased (+), decreased (-), or converged (*) at the locations tested. (details)
  75. Updates to Newton. Neater verbose outputs to console for residual. Tracking nonlinear iterations taken correctly for cases where Newton does not converge. (details)
  76. Update PDEmitAVSensor2D and PDEmitAVSensor3D to better handle the afld, including system tests to ensure consistency. This required a few changes in the PDEEulermitAVDiffusion classes (more to changes to come with these). Also added a h/p scaling for the 2D sensor viscosity with unit test. (details)
  77. Removed duplicated class definition in two cpp files, which may have led to unitialized data error reported by valgrind. (details)
  78. Fix nightly script (details)
  79. Another nightly script fix (details)
  80. Updates to Euler/NS mainly to improve the custom tecplot output. Updates to artificial diffusion classes to remove the a-field from params, since those should all be handled by the PDESensor classes now. Updates to the custom tecplot output function for RANSSA so we get the SA variable in the domain, and RANSSA fluxes at the boundary. Added PDEEulermitAVDiffusion3D.h to the exclusion list for file size. Updates to boundary conditions mostly to handle the a-field in the params in a cleaner way. (details)
  81. Renamed analytic functions with array output to hopefully avoid confusion (details)
  82. Updated PDESourceOnly and unit tests. Required some modification of a few PDEs in the process. (details)
  83. Updated homotopy continuation algorithm. This involves an update to the constructor, so the relevent sandbox cases have been updated. A few sandbox cases and unit test have been disabled. The unit test will be re-enabled once it has been updated to the new interface (the content is currently lacking anyway). Also added a function to SolverInterface_VMSD_BR2 to return the total (q + qp) fine (p+1 without subtraction) adjoint for output to Tecplot. (details)
  84. Minor edits (details)
  85. Add ProjectToQauxi equation class for coupling FP+IBL3 (details)
  86. Rename VectorFunction3D to ArrayFunction based on new naming convention (details)
  87. Removed all the cases that were disabled in the sandbox. Re-added the homotopy unit tests (still need more work, but to check basic functionality). Updated advection-diffusion and PDEHomotopy interfaces to support the new unit test. (details)
  88. Add initial framework for Auxi equation for FP-IBL3 coupling (details)
  89. Minor cleanup (details)
  90. Removing some secluded ntref values pointed out by Ben (details)
  91. add anonymous namespace for safety (details)
  92. Included all the necessary fields int Auxi equation for FP-IBL3 (details)
  93. Renamed integrand for projection to Qauxi (details)
  94. Added the ability to specify parameters for positivity preserving source in Euler. Updated tests to reflect change in constructor. (details)
  95. I think this will fix the error Jenkins bought up for the Euler with rotor PDE. (details)
  96. Fix Euler with rotor PDE boundary condition (details)
  97. Fix Euler with rotor PDE boundary condition -- Surreals could be passed through the PointSequence too. (details)
  98. Removed unused header from Homotopy.h (details)
  99. Warning fixes (details)
  100. More warning fixes for missing override keyword. (details)
  101. Update to latest avro (details)
  102. avro parallel fixes (details)
  103. Dissable avro graphics (details)
  104. add const qualifier just to be extra cautious (details)
  105. Initial working prototype of projection to Qauxi without the div.(M) term (details)
  106. Distinguish volume and manifold quadrature order configurations (details)
  107. Rename integrand class for clarity (details)
  108. 4D fixes, and rename Ptope to Pentatope (details)
  109. Missed a file (details)
  110. Remove file dump (details)
  111. Fix warning (details)
  112. Add initial API of manifold integrands for Auxi equation (details)
  113. Put avro WriteConformity back, but does nothing for now (details)
  114. add more details to integrand of manifold boundary trace for FP-IBL3 coupling (details)
  115. More avro parameter fixes (details)
  116. Reduce Pentatope mesh size. Fix accidental commit (details)
  117. Warning fix (details)
  118. rename files/classes for clarity (details)
  119. add missing include (details)
  120. [intermediate progress] compiling prototype of manifold boundary trace integrals in auxi equation for FP-IBL3 coupling (details)
  121. minor edit (details)
  122. Removed unnecessary destructor (details)
  123. typo fix (details)
  124. Access cell group via global indexing instead of local (details)
  125. Initial working prototype of new Field for Qauxi for FP-IBL3 so that DOFs can be viewed as volume boundary trace and area cell at the same time (details)
  126. Type-related bugfix in FP PDE (details)
  127. cleaned up unused method (details)
  128. Updated VMSDBR2 statically condensed Jacobian calculating to accept multiple RHS to condense using a single Jacobian calculation. Updated linear solvers for globally constrained systems to use this new functionality. Added unit tests to test that results from multiple-RHS code matches applying the single-RHS code to each RHS individually. This update will only affect globally constrained systems (using VMSDBR2). (details)
  129. Hard coded manifold/surface quad grid that matches z-min boundary group of a box hex grid (details)
  130. Added comments to BC data field implementation (details)
  131. Minor typo fix (details)
  132. Refactored DOF indexing contruction to ensure consistency between volumeb boundary trace field and area cell field (details)
  133. Rename variable for clarity.  Add exception to guard against misuse of BC data in full potential wall transpiration BC (details)
  134. Start a new case of FP-IBL3 coupling by copying from existing FP-only case. (details)
  135. Fixed clang warnings. Fixed abstract class error due to not implementing static condensation update to MKL. Have added a developer exception so the execution path exists, but extension still not implemented for MKL. (details)
  136. Refactored AES Project to Qauxi for flat plate 3D panel so that it's ready to be generalized for 3D FP coupling as well (details)
  137. Removed a deprecated header file (details)
  138. Add partial specialization to support block 4x4 FP+IBL3 coupling (details)
  139. Fixed missing BC parameter checks (details)
  140. Fixed long line formatting (details)
  141. Fixed more intel warnings. Added unit tests for the multi-RHS logic for UMFPack and MKL. The MKL test ensures that a developer excpetion occurs, since the logic for MKL has not been implemented. Moved the sum-constrained algebraic equation set in to its own file (like the Advection and Heat equation sets). (details)
  142. minor cleanup (details)
  143. Add static data member to identify the size of jacobian (i.e. number of equations and variables) (details)
  144. Add unit test for block 4x4 system of FP-IBL3 coupling. Still a working progress, but test compiles and runs (details)
  145. Fixed more intel warnings. Added unit tests for the multi-RHS logic for FMGRES. The FGMRES test ensures that a developer excpetion occurs, since the logic for MKL has not been implemented. (details)
  146. Completed Auxi equation for FP-IBL3 coupling (details)
  147. Fix a bug in block 3x3 and 4x4 system of equations: MatrixSize().  It has been identified because perviously block (2,1) is decoupled/zero for previous test cases (details)
  148. Refactor jacobian ping test screen output for clarity (details)
  149. Refactor JacobianParam to allow for multiple parameters of different dimension, e.g. for Auxi equation of FP-IBL3 coupling (details)
  150. Pass block 4x4 block algebraic equation set unit test without coupling for FP and Auxv equations (details)
  151. add const qualifiers (details)
  152. Add annotation to AES_Auxi (details)
  153. Remove redundant class template arguments (details)
  154. Remove AGLS. Add blockage and viscous terms to RotorSource. (details)
  155. Missed a file (details)
  156. Refator AES_auxv mass matrix jacobian computation for clarity and simplicity (details)
  157. BC fixes (details)
  158. Fix include (details)
  159. More boundary condition cleanup (details)
  160. Relax tolerance (details)
  161. Warning fix (details)
  162. Auxi parameter jacobian is now compiling. (details)
  163. Rename class and file (details)
  164. Added functionality to project from a DG to a CG field defined on the same x-field. (details)
  165. Remove infinite x-dervative for thickenss. Fix warnings. (details)
  166. DG ot CG prjection now uses explicit instantiation. (details)
  167. Simplify jacobian calculation of Auxi equation as it's simply mass matrix for Galerkin projection (details)
  168. Add a specialized IntegrateCellGroups method for reuse in FP-IBL3 coupling implementation (details)
  169. More strict templates for AV. Add strongFluxViscous to AV. (details)
  170. Warning fixes (details)
  171. Fix for older cmake versions (details)
  172. Replace max with smoothRamp_tanh2 for artificial viscosity (details)
  173. Some more tests (details)
  174. Fix smoothRamp_tanh2. Fix ThicknessNACA6 to use fabs instead of abs. (details)
  175. Suppress compiler warning (details)
  176. Fix warning and relax tolerance (details)
  177. Enable viscous body forces for Euler (details)
  178. Completed Auxv_Qinv jacobian (details)
  179. Added a test to check that bubble modes were not present in VMSD after static condenstaion for a partial Newton step. (details)
  180. Vera exclusion needed for new unit test (L006). (details)
  181. Added parallel test for homotopy, found bug in parallel, fixed bug in parallel. (details)
  182. Discrete blockage gradient (details)
  183. Forgot a file (details)
  184. Added an example homotopy adapt in 3D with RANS, and some missing function calls. (details)
  185. Vera fix (details)
  186. Fix compile error (details)
  187. Added HiFW Joukowski case using homotopy (still WIP). Updates to artificial viscosity interface to resolve some template mis-matches during Joukowski case set up. (details)
  188. Add annotations (details)
  189. Another compile fix (details)
  190. Another compile fix (details)
  191. Fixed error in PETSc Dicts. (details)
  192. Relax tolerance. Add PETScInit. Suppress warning. (details)
  193. More warning fixes (details)
  194. PDERANS3D fixes (details)
  195. Fixes for AVSensor_Source_VMSD_SPD (details)
  196. Fix ping test (details)
  197. Change git update alias (details)
  198. Fix sensitvity calculation (details)
  199. Don't require name for camber free parameters (details)
  200. Implement BCNone for VMSD BR2. I hope nobody has been using it... (details)
  201. Completed d(FP)/d(Qauxi) coupling jacobian for FP-IBL (details)
  202. Forgot to commit unit test on d(FP)/d(Qauxi) jacobian (details)
  203. Removed redundant files for discarded Auxi and Auxv equation implementation (details)
  204. Removed more discarded implementation for Auxi (in FP-IBL3) (details)
  205. Add linear algebra instantiations for FP-IBL3 (details)
  206. Refactoring to keep up with JacobianParam's updated template arguments (details)
  207. Fixed formatting (details)
  208. Minor refactoring (details)
  209. Add unit test for box grid and its derived boundary manifold grid (details)
  210. Minor cleanup (details)
  211. Add more unit test (details)
  212. Add unit test for FieldVolume_DG_BoundaryTrace_matchAreaCell (details)
  213. Bug fix: previously, allocated memory for dynamic matrix but didn't initialize to zero (details)
  214. Completed 4x4 block system jacobian ping test for FP-IBL3 coupling (details)
  215. Added Tt output for Rotor (details)
  216. added instantiations for Newton solution of FP-IBL3 equations (details)
  217. Solved first FP-IBL3 case with Newton solver (details)
  218. added instantiations for MKL and PETSc for FP-IBL3 (details)
  219. added implementation for PETSc for FP-IBL3 (details)
  220. modularized S-shaped duct grid points generation (details)
  221. debugging (for sporadically slow FP residual/jacobian) and refactoring FP-IBL3 test case (details)
  222. Added more profiling info for debugging FP-IBL3 (details)
  223. added verbose printout for debugging (details)
  224. fixed formatting errors (details)
  225. Fix Tt rotor output (details)
  226. Fixes for triangle (details)
  227. Fix for triangle with holes (details)
  228. some cleanup on full potential PDE (details)
  229. refactored and added to residualDecreaseStatus(.) (details)
  230. fixed over-array-bound access (details)
  231. switched assertions from runtime to compile time (details)
  232. refactored FP-IBL3 S-duct test case (details)
  233. forgot to commit this... refactored linear solution checker (details)
  234. removed redundant partial specialization in AES_PTC (details)
  235. annotated PTC implementation of paramfld_ and paramfldpast_ (details)
  236. beautified Newton iteration printout (details)
  237. refactored an MatrixS constructor (details)
  238. added comments (details)
  239. enabled PTC for FP-IBL3 4x4 coupling (details)
  240. fixed FP and IBL side wall BC (details)
  241. refactored std::vector access to use bound checking (details)
  242. added comments on how/why CFL changes in PTC iterations (details)
  243. refactored PTC printout & dump (details)
  244. minor tweak to test case (details)
  245. Refactored S-duct box grid (details)
  246. Cleaned up 3D FP BC (details)
  247. some cleanup (details)
  248. added commented out code for timing (details)
  249. fixed warnings (details)
  250. added sanity check.  some cleanup (details)
  251. changed IBL3 surface normal orientation convention to be compatible with FP-IBL3 coupling (details)
  252. Refactored projection onto Qauxv to be only in-surface velocity components in FP-IBL3 coupling (details)
  253. added assertion to guard against misuse (details)
  254. Consolidated auxi equation implementation for 3D full potential and panel (details)
  255. minor cleanup (details)
  256. Merged ProjectToQauxi3D implementation for panel and FP coupling with IBL3 (details)
  257. more cleanup on include (details)
  258. Cleaned up and merged interior trace integrand for IBL3 and Auxi.  Renamed files (details)
  259. added missing include that was accidentally removed (details)
  260. cleaned up include related to 2D/3D manifold cell integrands (details)
  261. more cleanup of include (details)
  262. Cleaned up panel+IBL3 case (details)
  263. added option in IBL3 to choose how nrm_surf orientation relates to e1 and e2 (details)
  264. minor test case cleanup/tweaks (details)
  265. turned off (1) LF flux, (2) mass correction to flux and (3) amp+lag equations for IBL3 (details)
  266. fixed style (details)
  267. refactored param tuple type for better consistency between indexing, ParamTuple and FieldTuple (details)
  268. renamed parameter field type (details)
  269. refactored parameter type for IBL3 (details)
  270. refactored JacobianParam class since the previous implementation is quite limiting (details)
  271. updated JacobianParam usage in test cases following its refactoring (details)
  272. more cleanup on JacobianParam usage (details)
  273. updated use cases involving Auxi equation in panel+IBL3. deleted sandbox cases that are not worth maintaining (details)
  274. updated use cases of new PDEIBL3FourEqn API (details)
  275. fixed full potential unit tests (details)
  276. fixed a bug/typo: flipped divM and divM_rhoe flux calculation for Auxi. Fortunately, the effect on current test cases is minimal since they are incompressible flows (details)
  277. fixed IBL unit tests (details)
  278. minor cleanup of 3D IBL PDE and associated block jacobian ping test (details)
  279. Removed the dedicated (yet redundant) boundary trace integrand for 3D auxi; instead, use 3D manifold BCNone integrand.  Renamed 2D/3D BCNone integrands to reflect its general purpose, not limited to IBL PDE (details)
  280. refactored/fixed Surreal type definitions to use proper/general size variable (details)
  281. accidentally forgot these pieces two commits earlier, when updating auxi BCNone integrand (details)
  282. fixed some compile errors for auxi equation and boundary integrand (details)
  283. minor integrand cleanup (details)
  284. refactored auxi equation's cell integrand to be PhysDim-agnostic, in prep for generalization of auxi aes class (details)
  285. Renamed auxi aes class to be not 3D specific, in prep for generalization (details)
  286. Refactored BCNone integrand for Galerkin manifold to be agnostic of PhysDim (details)
  287. fixed/refactored a few Galerkin_manifold boundary integands to be agnostic of PhysDim (details)
  288. Use isotropic implied metric for IsotropicOpt MOESS (details)
  289. refactored Galerkin_manifold interior trace integrands to be agnostic of PhysDim (details)
  290. removed daisy chain in JacobianParam since it could be handled by the primary algebraic equation class's jacobianParam(...) (details)
  291. removed 3D-specific assertion (details)
  292. refactored usage of jacobianParam(...) to account for any daisy chain in the primary algebraic equation set (details)
  293. Refactored daisy-chain/linked list implementation of algebraic equation sets, including auxi equation and proper chained calls to jacobianParam() (details)
  294. removed redundant daisy-chained calls to setSolutionField() and fillSystemVector() in algebraic equation sets.  Clarified the intended use case of daisy-chained equation set (details)
  295. Refactored 2D auxi PDE class to prepare panel-IBL2 to use the PhysDim-agnostic auxi equation implementation.  Removed redundant auxi equation set and integrand classes that used to be specialized for Panel2D (details)
  296. Removed 3D-specific assertion in auxi cell integrand. Fixed IBL2 captured transition system test case (details)
  297. Cleaned up auxi equation implementation to remove redundant dummy members in FunctionEval class.  Renamed some files & classes (details)
  298. cannot assign a regular/raw pointer to std::shared_ptr (details)
  299. Cleaned up 2D auxv equation implementation for XfoilPanel+IBL to remove redundant dummy members in FunctionEval class.  Renamed some files & classes (details)
  300. cannot assign regular/raw pointer to std::shared_ptr (details)
  301. Cleaned up 3D auxv equation implementation for flat plate panel+IBL3 to remove redundant dummy members in FunctionEval class (details)
  302. minor refactoring of XfoilPanel field discretization order checks/assertions (details)
  303. refactoring (similar to previous ones) to have PDEIBL2D define its parameter field tuple types (details)
  304. typo fix (details)
  305. only prints in verbose mode (details)
  306. fixed system/CodeConsistency tests for IBL (details)
  307. cleanup and fixes to keep IBL-related implementation up to date (details)
  308. more cleanup on DG/HDG discretization unit tests, mostly related to IBL (details)
  309. cleanup & fixes to panel-IBL3 3x3 block discretization unit tests to keep up to date with IBL-related implementation (details)
  310. removed redundant include (details)
  311. fixed miscellaneous XfoilPanel+IBL2 aes unit tests to stay up to date with latest IBL implementation (details)
  312. cleaned up & fixed sandbox cases for XfoilPanel+IBL2D single run and drag polar for airfoil (details)
  313. miscellanenous fixes of compile error and formatting style (details)
  314. removed uses of gradqn and q in Neumann and Dirichlet BCs respectively for potential flow (details)
  315. fixed some compile errors and formatting style (details)
  316. updated pyrite check files for IBLFourEqn3D to use LF flux without mass correction (details)
  317. fixed miscellaneous unit tests related to coupled IBL (details)
  318. fixed FP-IBL3 jacobian ping test (details)
  319. fixed a few compile errors and warnings related to a few sandbox test cases not up-to-date with latest FullPotential PDE/BC implementation (details)
  320. allows FP-IBL3 jacobian ping test to run longer on Jenkins (details)
  321. fixed unit test of auxv aes for 3D full potential (details)
  322. Reverted some changes in the use of LIP BCs.  These changes should NOT have been made (details)
  323. relocated a unit test to IBL folder (details)
  324. passed a few ping tests related to coupled IBL3 (details)
  325. fixed two unit tests troubled by misuse of MPI communicator (details)
  326. relaxed time limit for a block jacobian ping test on Jenkins.  trying to fix an undefined reference error by altering the order of loading lib in CMakeLists (details)
  327. Looks like Jenkins censored the previous commit msg cuz it contains the word 'e-r-r-o-r'. Amend the commit msg now. relaxed time limit for a block jacobian ping test on Jenkins.  trying to fix an undefined reference e-r-r-o-r by altering the order of loading lib in CMakeLists (details)
  328. relaxed machine precision level tolerance in a unit test for intel compiler to pass (details)
  329. fix no-return warnings in a function with non-void return type (details)
  330. fix missing return statement issue (details)

Started by upstream project SANS_refine_poll build number 92
originally caused by:

Revision: ab8ee4fe5358cf3575b9d0fae8556c2b5b72290a
Repository: ssh://
  • acdl/develop
SCM: git ssh://
  • Commits since last build: 200
  • Latest commit: ab8ee4f
Static Analysis: No warnings
  • No issues for 46 builds, i.e. since build: #74
  • Reference build: SANS_refine #118
  • Quality gate: Success