BUILD_CAUSE | UPSTREAMTRIGGER |
BUILD_CAUSE_UPSTREAMTRIGGER | true |
BUILD_DISPLAY_NAME | #3228 |
BUILD_ID | 3228 |
BUILD_NUMBER | 3228 |
EXECUTOR_NUMBER | 2 |
GIT_BRANCH | thegreatpylintrefactorof2024 |
HOME | /Users/jenkins |
HUDSON_HOME | /var/lib/jenkins |
HUDSON_SERVER_COOKIE | e124851fc3e0704d |
HUDSON_URL | https://acdl.mit.edu/csi/ |
JAVA_MAIN_CLASS_3296 | hudson.remoting.Launcher |
JENKINS_HOME | /var/lib/jenkins |
JENKINS_SERVER_COOKIE | e124851fc3e0704d |
JENKINS_URL | https://acdl.mit.edu/csi/ |
LOGNAME | jenkins |
NODE_LABELS | macys_VM |
NODE_NAME | macys_VM |
OLDPWD | /Users/jenkins |
PATH | /usr/bin:/bin:/usr/sbin:/sbin |
PWD | /Users/jenkins |
ROOT_BUILD_CAUSE | GHPRBCAUSE |
ROOT_BUILD_CAUSE_GHPRBCAUSE | true |
SHELL | /bin/bash |
SHLVL | 1 |
SSH_CLIENT | 18.18.33.14 37752 22 |
SSH_CONNECTION | 18.18.33.14 37752 10.33.1.231 22 |
TMPDIR | /var/folders/qk/9zkf0syn149fvhw9mh7hgd5w0000gp/T/ |
USER | jenkins |
_ | /usr/bin/java |
__CF_USER_TEXT_ENCODING | 0x1F6:0:0 |
buildnode | macys_VM |
ghprbActualCommit | 485d413e5893d2139d97067a3cc732d08a750368 |
ghprbActualCommitAuthor | Warren Hoburg |
ghprbActualCommitAuthorEmail | whoburg@alum.mit.edu |
ghprbAuthorRepoGitUrl | https://github.com/whoburg/gpkit.git |
ghprbCommentBody | null |
ghprbCredentialsId | 2a2b74d8-fbb8-4038-938a-85796af1b79f |
ghprbGhRepository | convexengineering/gpkit |
ghprbPullAuthorLogin | whoburg |
ghprbPullAuthorLoginMention | @whoburg |
ghprbPullDescription | GitHub pull request #1578 of commit 485d413e5893d2139d97067a3cc732d08a750368, no merge conflicts. |
ghprbPullId | 1578 |
ghprbPullLink | https://github.com/convexengineering/gpkit/pull/1578 |
ghprbPullLongDescription | Alright, I bit the bullet and got the entire `gpkit/` package up to date with the latest pylint (pylint 3.0.3). My goal was to reduce custom rcfile settings, use local pylint disable statements where warranted, and get the code base in line with the latest pylint with default settings.\r\n\r\nI did identify three warnings (disabled in the current PR) that I feel warrant opening issues to address:\r\n - significant chuck of duplicate code in `solution_array.py` and in `constraints/set.py`\r\n - numerous cyclic import warnings\r\n - a `modified-iterating-list` warning in `interactive/plotting.py`, warning that a value `parents` used to control iteration in a loop is also being modified within that same loop\r\n\r\nThis PR currently handles the `gpkit` directory, including `gpkit/tests`, but does not touch `docs/source/examples` at all. That can be the next pylint PR.\r\n\r\nReview definitely warranted and welcome. |
ghprbPullTitle | big pylint refactor |
ghprbSourceBranch | thegreatpylintrefactorof2024 |
ghprbTargetBranch | master |
optimizer | cvxopt |
sha1 | origin/pr/1578/merge |